lkml.org 
[lkml]   [2013]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 2/2] sched/rt: add a tuning knob to allow changing SCHED_RR timeslice
On Sun, 3 Feb 2013 19:57:09 +0100
Ingo Molnar <mingo@kernel.org> wrote:

>
> * Ingo Molnar <mingo@kernel.org> wrote:
>
> > The first patch looks good, I've applied it.
>
> I've skipped this one after all, as it sometimes generates:
>
> include/linux/sched/sysctl.h:108:41: warning: ‘struct signal_struct’ declared inside parameter list [enabled by default]
>
> Sometimes doesn't built kernel/sched/auto_group.c. So those bits
> probably want to move into a separate sched/auto_group.h header
> or so.
>
> But, more fundamentally, I think sched.h should not include the
> new sched/sysctl.h file. The whole point is to move out bits
> from sched.h and decouple them from sched.h - to shrink sched.h
> in the long run.
>
> Thanks,
>
> Ingo

Ahh, you wanted to not only reduce the size of sched.h you want to
reduce the amount of code it brings in.

I'll go back to the drawing board. I'll pull the relevant code from
sysctl.h into auto_group.h, then I'll remove the include in sched.h.
Then I'll track down all the build failures from the above :).

Clark
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-02-04 03:42    [W:0.054 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site