lkml.org 
[lkml]   [2013]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 06/26] mfd: ab8500-sysctrl: Provide configuration for SysClkReqRfClkBuf registers
Hi Lee,

On Mon, Jan 28, 2013 at 08:38:16AM +0000, Lee Jones wrote:
> On Mon, 28 Jan 2013, Samuel Ortiz wrote:
>
> > Hi Lee, Kennet,
> >
> > On Tue, Jan 15, 2013 at 12:55:46PM +0000, Lee Jones wrote:
> > > From: Kennet Wallden <kennet.wallden@stericsson.com>
> > >
> > > Add the possibility to pass configuration settings for
> > > SysCl1kReqRfClkBuf to SysClk8ReqRfClkBuf via platform data.
> > >
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > Signed-off-by: Kennet Wallden <kennet.wallden@stericsson.com>
> > > Reviewed-by: Karl-Johan PERNTZ <karl-johan.perntz@stericsson.com>
> > > Reviewed-by: Bengt JONSSON <bengt.g.jonsson@stericsson.com>
> > > ---
> > > drivers/mfd/ab8500-sysctrl.c | 25 +++++++++++++++++++++++++
> > > include/linux/mfd/abx500/ab8500-sysctrl.h | 5 +++++
> > > include/linux/mfd/abx500/ab8500.h | 2 ++
> > > 3 files changed, 32 insertions(+)
> > >
> > > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c
> > > index cf58f69..19a024e 100644
> > > --- a/drivers/mfd/ab8500-sysctrl.c
> > > +++ b/drivers/mfd/ab8500-sysctrl.c
> > > @@ -113,11 +113,36 @@ int ab8500_sysctrl_write(u16 reg, u8 mask, u8 value)
> > > static int __devinit ab8500_sysctrl_probe(struct platform_device *pdev)
> > > {
> > > struct ab8500_platform_data *plat;
> > > + struct ab8500_sysctrl_platform_data *pdata;
> > >
> > > sysctrl_dev = &pdev->dev;
> > > plat = dev_get_platdata(pdev->dev.parent);
> > > if (plat->pm_power_off)
> > > pm_power_off = ab8500_power_off;
> > > +
> > > + pdata = plat->sysctrl;
> > > +
> > > + if (pdata) {
> > > + int ret;
> > > + int i;
> > > + int j;
> > Cosmetic
> > int i, j, ret;
>
> Hmmm... this is how I'd prefer it too,
Great, I'm glad we agree :)

> but other maintainers prefer
> one-per-line. It would be better if we could standardise it somewhere
> to prevent unnecessary fixups.
I certainly don't like that coding style and I sincerely believe a vast
majority of the kernel code avoids it as well.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/


\
 
 \ /
  Last update: 2013-02-03 18:41    [W:0.068 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site