lkml.org 
[lkml]   [2013]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] netfilter: fix missing dependencies for NETFILTER_XT_MATCH_CONNLABEL
On 02/03/13 03:24, Florian Westphal wrote:
> It was possible to set
> NF_CONNTRACK=n
> NF_CONNTRACK_LABELS=y
>
> via NETFILTER_XT_MATCH_CONNLABEL=y:
>
> warning: (NETFILTER_XT_MATCH_CONNLABEL) selects NF_CONNTRACK_LABELS which has
> unmet direct dependencies (NET && INET && NETFILTER && NF_CONNTRACK)
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Florian Westphal <fw@strlen.de>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
> index eb2c8eb..d4dd702 100644
> --- a/net/netfilter/Kconfig
> +++ b/net/netfilter/Kconfig
> @@ -860,6 +860,7 @@ config NETFILTER_XT_MATCH_CONNBYTES
> config NETFILTER_XT_MATCH_CONNLABEL
> tristate '"connlabel" match support'
> select NF_CONNTRACK_LABELS
> + depends on NF_CONNTRACK
> depends on NETFILTER_ADVANCED
> ---help---
> This match allows you to test and assign userspace-defined labels names
>


--
~Randy


\
 
 \ /
  Last update: 2013-02-03 17:41    [W:0.049 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site