lkml.org 
[lkml]   [2013]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 078/128] fs/cifs/cifs_dfs_ref.c: fix potential memory leakage
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Cong Ding <dinggnu@gmail.com>

    commit 10b8c7dff5d3633b69e77f57d404dab54ead3787 upstream.

    When it goes to error through line 144, the memory allocated to *devname is
    not freed, and the caller doesn't free it either in line 250. So we free the
    memroy of *devname in function cifs_compose_mount_options() when it goes to
    error.

    Signed-off-by: Cong Ding <dinggnu@gmail.com>
    Reviewed-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Steve French <smfrench@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/cifs/cifs_dfs_ref.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/fs/cifs/cifs_dfs_ref.c b/fs/cifs/cifs_dfs_ref.c
    index ce5cbd7..210fce2 100644
    --- a/fs/cifs/cifs_dfs_ref.c
    +++ b/fs/cifs/cifs_dfs_ref.c
    @@ -226,6 +226,8 @@ compose_mount_options_out:
    compose_mount_options_err:
    kfree(mountdata);
    mountdata = ERR_PTR(rc);
    + kfree(*devname);
    + *devname = NULL;
    goto compose_mount_options_out;
    }




    \
     
     \ /
      Last update: 2013-02-03 17:21    [W:29.761 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site