Messages in this thread | | | Date | Thu, 28 Feb 2013 14:53:19 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 2/3] cgroup: add cgroup_name() API |
| |
On 2013/2/27 21:23, Tejun Heo wrote: > On Wed, Feb 27, 2013 at 2:49 AM, Li Zefan <lizefan@huawei.com> wrote: >> Well, cgrp->name is a pointer to struct cgroup_name. >> >> At first I tried to declare cgrp->name as char *, and use container_of() >> to get struct cgroup_name, but it didn't result in simpler code. > > Hmmm? But then what prevents defining const struct cgroup_name? > > static const struct cgroup_name root_cgroup_name = { .name = "/" };
Can't... That's char name[0] not char *name.
I'll allocate a global struct cgroup_name *root_cgroup_name, and use it for all root_cgroup->name and dummytop->name.
| |