lkml.org 
[lkml]   [2013]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 3/4] regulator: palmas: Removing duplicated code
Date
Hello Stephen,

> -----Original Message-----
> From: Stephen Warren [mailto:swarren@wwwdotorg.org]
> Sent: Thursday, February 28, 2013 12:05 AM
> To: J, KEERTHY
> Cc: broonie@opensource.wolfsonmicro.com; lgirdwood@gmail.com; linux-
> kernel@vger.kernel.org; gg@slimlogic.co.uk
> Subject: Re: [PATCH 3/4] regulator: palmas: Removing duplicated code
>
> On 02/17/2013 10:14 PM, J Keerthy wrote:
> > Removing duplicate assignment in the existing code.
> ...
> > diff --git a/drivers/regulator/palmas-regulator.c
> > b/drivers/regulator/palmas-regulator.c
> ...
> > @@ -566,11 +566,6 @@ static void palmas_dt_to_pdata(struct device
> *dev,
> > pdata->reg_init[idx]->mode_sleep = prop;
> >
> > ret = of_property_read_u32(palmas_matches[idx].of_node,
> > - "ti,warm_reset", &prop);
> > - if (!ret)
> > - pdata->reg_init[idx]->warm_reset = prop;
> > -
> > - ret = of_property_read_u32(palmas_matches[idx].of_node,
>
> Can you point out where the duplicate of that is; I don't see any other
> assignment to warm_reset.

As pointed out by Graeme this is already fixed.

Regards,
Keerthy


\
 
 \ /
  Last update: 2013-02-28 07:01    [W:0.085 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site