lkml.org 
[lkml]   [2013]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [REPOST PATCH 1/2] clk: add table lookup to mux
On Fri, 22 Feb 2013 16:02:28 +0100
Peter De Schrijver <pdeschrijver@nvidia.com> wrote:

> Add a table lookup feature to the mux clock. Also allow arbitrary masks
> instead of the width. This will be used by some clocks on Tegra114.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
....
> @@ -42,7 +43,17 @@ static u8 clk_mux_get_parent(struct clk_hw *hw)
> * val = 0x4 really means "bit 2, index starts at bit 0"
> */
....
> + if (mux->table) {
> + int i;
> +
> + for (i = 0; i < num_parents; i++)
> + if (mux->table[i] == val)
> + return i;
> + if (i == num_parents)
> + return -EINVAL;
> + }

Can't we just return after for-loop without checking i == num_parents as below?

+ for (i = 0; i < num_parents; i++) {
+ if (mux->table[i] == val)
+ return i;
+ }
+
+ return -EINVAL;


\
 
 \ /
  Last update: 2013-02-27 08:01    [W:0.396 / U:1.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site