lkml.org 
[lkml]   [2013]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] perf annotate: Fix build with NO_NEWT=1
Date
Hi Michael,

On Tue, 26 Feb 2013 16:02:02 +1100, Michael Ellerman wrote:
> Commit 18c9e5c "Make it to be able to skip unannotatable symbols" broke
> the build with NO_NEWT=1:
>
> CC builtin-annotate.o
> builtin-annotate.c: In function 'hists__find_annotations':
> builtin-annotate.c:161:4: error: duplicate case value
> builtin-annotate.c:154:4: error: previously used here
> make: *** [builtin-annotate.o] Error 1
>
> This is because without NEWT support K_LEFT is #defined to -1 in
> utils/hist.h
>
> Fix it by shifting the K_LEFT/K_RIGHT #defines out of the likely range
> of error values.

Argh, didn't check NO_NEWT build on this, sorry.

The hist_entry__tui_annotate() - hence, symbol__tui_annotate() - returns
either key code or error code. This is not good IMHO but not sure it's
worth refactoring. Maybe we can move the error check to under default
case so that possible future error checks to be done?

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-02-26 10:46    [W:0.109 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site