lkml.org 
[lkml]   [2013]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [GIT PULL] ACPI and power management fixes for v3.9-rc1
On 02/27/2013 12:28 AM, Linus Torvalds wrote:
> Ugh. Forgot to actually add the ODD people to the list...
>
> Linus
>
> On Tue, Feb 26, 2013 at 8:27 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> On Tue, Feb 26, 2013 at 8:10 AM, Nishanth Menon <nm@ti.com> wrote:
>>> On 16:55-20130226, Rafael J. Wysocki wrote:
>>>>
>>>> It says that in "Introduction", but it would be clearer if the title of the
>>>> doc was something like "Operating Performance Points (OPP) Library". Nishanth?
>>>
>>> Yes indeed. Will the following help? I can post it as an official patch
>>> if the direction is proper
>>
>> Yes, this will definitely help. I didn't even find it in the
>> introduction (Rafael is correct that it is indeed there), because it's
>> hard to see when you don't know what to scan for and it's in a big
>> block of text.
>>
>> I am also happy to note that it is in the Kconfig help and single-line
>> description. Which wasn't true for the new SATA_ZPODD ("Zero Power
>> ODD" - what the heck is ODD?) which was another new entry I wondered
>> about.

Sorry about this.

>>
>> It turns out that ODD is an odd TLA for "Optical Disk Drive". I'm sure
>> it makes perfect sense if you are a SATA person, but it sure doesn't
>> for any normal human being, even otherwise highly technical ones.
>>
>> Aaron, Tejun, Jeff, can I ask you to also not use specialized TLA's
>> without explaining them? Especially in help text and "documentation",
>> it's very unhelpful to have TLA's that aren't common.

OK.
I hope the following is better, if so, I'll send out a patch.

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 9b58d32..b75efb0b 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -59,15 +59,16 @@ config ATA_ACPI
option libata.noacpi=1

config SATA_ZPODD
- bool "SATA Zero Power ODD Support"
+ bool "SATA Zero Power Optical Disc Drive(ZPODD) support"
depends on ATA_ACPI
default n
help
- This option adds support for SATA ZPODD. It requires both
- ODD and the platform support, and if enabled, will automatically
- power on/off the ODD when certain condition is satisfied. This
- does not impact user's experience of the ODD, only power is saved
- when ODD is not in use(i.e. no disc inside).
+ This option adds support for SATA Zero Power Optical Disc
+ Drive(ZPODD). It requires both the ODD and the platform
+ support, and if enabled, will automatically power on/off the
+ ODD when certain condition is satisfied. This does not impact
+ end user's experience of the ODD, only power is saved when
+ the ODD is not in use(i.e. no disc inside).

If unsure, say N.

Thanks,
Aaron



\
 
 \ /
  Last update: 2013-02-27 04:01    [W:0.064 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site