Messages in this thread | | | Date | Tue, 26 Feb 2013 08:31:45 +0100 (CET) | From | Guennadi Liakhovetski <> | Subject | Re: [PATCH v2] Media: remove incorrect __init/__exit markups |
| |
On Mon, 25 Feb 2013, Dmitry Torokhov wrote:
> Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically disables sysfs bind/unbind > attributes. > > Similarly probe() methods should not be marked __init unless > platform_driver_probe() is used. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > > v1->v2: removed __init markup on omap1_cam_probe() that was pointed out > by Guennadi Liakhovetski. > > drivers/media/platform/soc_camera/omap1_camera.c | 6 +++---
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/
| |