lkml.org 
[lkml]   [2013]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 140/150] dma: sh: Dont use ENODEV for failing slave lookup
    Date
    3.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

    commit 7c1119bdd650fa58dad8157bc75c5fcf6ed97843 upstream.

    If dmaengine driver's .device_alloc_chan_resources() method returns -ENODEV,
    dma_request_channel() will decide, that the driver has been removed and will
    remove the device from its list. To prevent this use ENXIO if a slave lookup
    fails.

    Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
    Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/dma/sh/shdma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/dma/sh/shdma.c
    +++ b/drivers/dma/sh/shdma.c
    @@ -326,7 +326,7 @@ static int sh_dmae_set_slave(struct shdm
    shdma_chan);
    const struct sh_dmae_slave_config *cfg = dmae_find_slave(sh_chan, slave_id);
    if (!cfg)
    - return -ENODEV;
    + return -ENXIO;

    if (!try)
    sh_chan->config = cfg;



    \
     
     \ /
      Last update: 2013-02-27 02:41    [W:3.114 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site