lkml.org 
[lkml]   [2013]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 02/13] PCI/acpiphp: use list_for_each_entry_safe() in acpiphp_sanitize_bus()
    Date
    From: Yijing Wang <wangyijing@huawei.com>

    Function acpiphp_sanitize_bus() may call pci_stop_and_remove_bus_device(),
    which in turn may remove device from bus->devices list. So walk the
    bus->devices list with list_for_each_entry_safe().

    Signed-off-by: Yijing Wang <wangyijing@huawei.com>
    Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
    Cc: Yinghai Lu <yinghai@kernel.org>
    Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
    Cc: Toshi Kani <toshi.kani@hp.com>
    Cc: linux-pci@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    ---
    drivers/pci/hotplug/acpiphp_glue.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
    index 4681d2c..514851d8 100644
    --- a/drivers/pci/hotplug/acpiphp_glue.c
    +++ b/drivers/pci/hotplug/acpiphp_glue.c
    @@ -1086,11 +1086,11 @@ static void acpiphp_set_hpp_values(struct pci_bus *bus)
    */
    static void acpiphp_sanitize_bus(struct pci_bus *bus)
    {
    - struct pci_dev *dev;
    + struct pci_dev *dev, *tmp;
    int i;
    unsigned long type_mask = IORESOURCE_IO | IORESOURCE_MEM;

    - list_for_each_entry(dev, &bus->devices, bus_list) {
    + list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list) {
    for (i=0; i<PCI_BRIDGE_RESOURCES; i++) {
    struct resource *res = &dev->resource[i];
    if ((res->flags & type_mask) && !res->start &&
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2013-02-26 17:02    [W:2.494 / U:0.772 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site