Messages in this thread | | | Date | Tue, 26 Feb 2013 19:23:20 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH v2 2/2] mfd: palmas add variant and OTP detection |
| |
On Saturday 23 February 2013 10:05 PM, Ian Lartey wrote: > From: Graeme Gregory <gg@slimlogic.co.uk> > > Read the chip varient and the OTP information from the chip and display > this on probe to aid in debugging of issues. > > Older palmas chips do not have the USB_ID programmed and will therefore > return 0x0000 for this field.
> + > /* Change IRQ into clear on read mode for efficiency */ > slave = PALMAS_BASE_TO_SLAVE(PALMAS_INTERRUPT_BASE); > - addr = PALMAS_BASE_TO_REG(PALMAS_INTERRUPT_BASE, PALMAS_INT_CTRL); > reg = PALMAS_INT_CTRL_INT_CLEAR; > > - regmap_write(palmas->regmap[slave], addr, reg); > + ret = palmas_write(palmas, PALMAS_INTERRUPT_BASE, PALMAS_INT_CTRL, reg); >
I think this is unrelated change and can be on another patch.
> > - slave = PALMAS_BASE_TO_SLAVE(PALMAS_PU_PD_OD_BASE); > - addr = PALMAS_BASE_TO_REG(PALMAS_PU_PD_OD_BASE, > - PALMAS_PRIMARY_SECONDARY_PAD1); > - > if (pdata->mux_from_pdata) { > reg = pdata->pad1; > - ret = regmap_write(palmas->regmap[slave], addr, reg); > + ret = palmas_write(palmas, PALMAS_PU_PD_OD_BASE, > + PALMAS_PRIMARY_SECONDARY_PAD1, reg);
Same, in another patch and elsewhere which was part of cleanups.
otherwise it looks good.
| |