lkml.org 
[lkml]   [2013]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] idr: Don't WARN in idr_find
On Mon, Feb 25, 2013 at 08:46:11PM -0500, Peter Hurley wrote:
> On Mon, 2013-02-25 at 17:40 -0800, Tejun Heo wrote:
> > On Mon, Feb 25, 2013 at 08:37:12PM -0500, Peter Hurley wrote:
> > > Since idr is used for syscall apis (to associate 'handles' with
> > > internal structures), don't WARN with invalid input.
> > >
> > > For example, POSIX timers are identified by timer_t id. These
> > > ids are idr values. If userspace passes a representable timer_t id
> > > value (eg, id < 0) but which was not previous allocated (since the
> > > current idr api does not return negative idr values), then the
> > > syscall properly returns an error; a WARN is unnecessary and
> > > undesirable.
> >
> > WARN_ON() on negative was intentional. Because the previous
> > implmentation silently dropped the msb, we at least wanna know who has
> > been passing in negative indices. Patch for the lock_timer is already
> > in -mm.
>
> Thanks. Can you share the patch title? It's not in next-20130225.

It's this one.

http://thread.gmane.org/gmane.linux.kernel/1444883/focus=1445094

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-02-26 03:21    [W:0.134 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site