Messages in this thread | | | From | Dongsheng Song <> | Date | Sun, 24 Feb 2013 17:51:44 +0800 | Subject | Re: [PATCH] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL |
| |
On Sun, Feb 24, 2013 at 1:03 AM, Kees Cook <keescook@chromium.org> wrote: > On Sat, Feb 23, 2013 at 3:59 AM, Dongsheng Song > <dongsheng.song@gmail.com> wrote: >> On Sat, Feb 23, 2013 at 3:29 PM, Kees Cook <keescook@chromium.org> wrote: >>> >>> The CONFIG_EXPERIMENTAL config item has not carried much meaning for a >>> while now and is almost always enabled by default. As agreed during the >>> Linux kernel summit, remove it from any "depends on" lines in Kconfigs. >>> >>> Signed-off-by: Kees Cook <keescook@chromium.org> >>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> >>> Cc: Mukesh Rathor <mukesh.rathor@oracle.com> >>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >>> --- >>> arch/x86/xen/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig >>> index 93ff4e1..8cada4c 100644 >>> --- a/arch/x86/xen/Kconfig >>> +++ b/arch/x86/xen/Kconfig >>> @@ -53,7 +53,7 @@ config XEN_DEBUG_FS >>> >>> config XEN_X86_PVH >>> bool "Support for running as a PVH guest (EXPERIMENTAL)" >> >> Why not remove this 'EXPERIMENTAL' too ? > > It was unclear to me if the feature was actually considered unstable. > I can resend with the text removed from the title too, if that's the > correct action here? > > -Kees >
If such a feature was considered unstable, it should depends on EXPERIMENTAL. We should not surprised users.
>> >>> - depends on X86_64 && XEN && EXPERIMENTAL >>> + depends on X86_64 && XEN >>> default n >>> help >>> This option enables support for running as a PVH guest (PV guest >>> -- >>> 1.7.9.5 >>> >>> >>> -- >>> Kees Cook >>> Chrome OS Security >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> Please read the FAQ at http://www.tux.org/lkml/ > > > > -- > Kees Cook > Chrome OS Security
| |