lkml.org 
[lkml]   [2013]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] backlight: ams369fg06: convert ams369fg06 to dev_pm_ops
Date
On Saturday, February 23, 2013 6:26 AM, Andrew Morton wrote:
>
> On Fri, 22 Feb 2013 19:42:59 +0900
> Jingoo Han <jg1.han@samsung.com> wrote:
>
> > Instead of using legacy suspend/resume methods, using newer dev_pm_ops
> > structure allows better control over power management.
> >
> > ...
> >
> > @@ -571,12 +571,13 @@ static struct spi_driver ams369fg06_driver = {
> > .driver = {
> > .name = "ams369fg06",
> > .owner = THIS_MODULE,
> > +#ifdef CONFIG_PM
> > + .pm = &ams369fg06_pm_ops,
> > +#endif
> > },
> > .probe = ams369fg06_probe,
> > .remove = ams369fg06_remove,
> > .shutdown = ams369fg06_shutdown,
>
> Are the ifdefs needed? There's various macro trickery in pm.h to clean
> this up - the rtc drivers use it.

OK, you're right.
I will remove unnecessary '#ifdef CONFIG_PM'.
Thank you for your comment.

Best regards,
Jingoo Han





\
 
 \ /
  Last update: 2013-02-25 03:21    [W:0.071 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site