Messages in this thread | | | From | Jingoo Han <> | Subject | Re: [PATCH] backlight: ams369fg06: convert ams369fg06 to dev_pm_ops | Date | Mon, 25 Feb 2013 10:51:19 +0900 |
| |
On Saturday, February 23, 2013 6:26 AM, Andrew Morton wrote: > > On Fri, 22 Feb 2013 19:42:59 +0900 > Jingoo Han <jg1.han@samsung.com> wrote: > > > Instead of using legacy suspend/resume methods, using newer dev_pm_ops > > structure allows better control over power management. > > > > ... > > > > @@ -571,12 +571,13 @@ static struct spi_driver ams369fg06_driver = { > > .driver = { > > .name = "ams369fg06", > > .owner = THIS_MODULE, > > +#ifdef CONFIG_PM > > + .pm = &ams369fg06_pm_ops, > > +#endif > > }, > > .probe = ams369fg06_probe, > > .remove = ams369fg06_remove, > > .shutdown = ams369fg06_shutdown, > > Are the ifdefs needed? There's various macro trickery in pm.h to clean > this up - the rtc drivers use it.
OK, you're right. I will remove unnecessary '#ifdef CONFIG_PM'. Thank you for your comment.
Best regards, Jingoo Han
| |