Messages in this thread | | | From | Alexander Shiyan <> | Subject | Re[2]: [PATCH v4] mfd: syscon: Add non-DT sup port | Date | Fri, 22 Feb 2013 11:01:18 +0400 |
| |
> On Thu, Feb 21, 2013 at 07:29:02PM +0400, Alexander Shiyan wrote: > > This patch allow using syscon driver from the platform data, i.e. > > possibility using driver on systems without oftree support. > > For search syscon device from the client drivers, > > "syscon_regmap_lookup_by_pdevname" function was added. > > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > > [...] > > > + syscon->base = devm_ioremap_resource(dev, res); > > + if (!syscon->base) > > Is this correct?
Hmm, of course IS_ERR should be used here... v5?
> > > + return -EBUSY; > > > > Otherwise, i'm also ok with this patch. > Acked-by: Dong Aisheng <dong.aisheng@linaro.org> > > BTW, i did not see Samuel's tree having this new API. > So, who will pick this patch?
I have same question.
---
| |