lkml.org 
[lkml]   [2013]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/11] mfd: tps65010: use devm_request_irq() and devm_kzalloc()
    On Wed, Feb 20, 2013 at 03:14:05PM +0900, Jingoo Han wrote:
    > Use devm_request_irq() and devm_kzalloc() to make cleanup paths
    > more simple.
    >
    > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
    > ---
    > drivers/mfd/tps65010.c | 15 +++++----------
    > 1 files changed, 5 insertions(+), 10 deletions(-)
    >
    > diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c
    > index da2691f..a5438cc 100644
    > --- a/drivers/mfd/tps65010.c
    > +++ b/drivers/mfd/tps65010.c
    > @@ -525,11 +525,8 @@ static int __exit tps65010_remove(struct i2c_client *client)
    > dev_dbg(&client->dev, "board %s %s err %d\n",
    > "teardown", client->name, status);
    > }
    > - if (client->irq > 0)
    > - free_irq(client->irq, tps);
    > cancel_delayed_work_sync(&tps->work);
    > debugfs_remove(tps->file);
    > - kfree(tps);
    > the_tps = NULL;
    > return 0;

    Nope, again work and IRQ have to be handled in certain order.

    Thanks.

    --
    Dmitry


    \
     
     \ /
      Last update: 2013-02-20 09:21    [W:4.281 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site