Messages in this thread | | | From | (Eric W. Biederman) | Date | Wed, 20 Feb 2013 12:31:19 -0800 | Subject | Re: [PATCH 1/1] kernel/fork.c: Simplifying a snippet of code. |
| |
"Raphael S.Carvalho" <raphael.scarv@gmail.com> writes:
> Just sending this patch in order to simplify the code. > However, I'm not sure if the code was written in that way due to > specific reasons.
That doesn't look any simpler to me, and I expect you have now biased the branch in the wrong direction.
The CLONE_THREAD is not the common case.
Eric
> Signed-off-by: Raphael S.Carvalho <raphael.scarv@gmail.com> > --- > kernel/fork.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/kernel/fork.c b/kernel/fork.c > index c535f33..237204d 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -1341,9 +1341,7 @@ static struct task_struct *copy_process(unsigned long clone_flags, > } > > p->pid = pid_nr(pid); > - p->tgid = p->pid; > - if (clone_flags & CLONE_THREAD) > - p->tgid = current->tgid; > + p->tgid = (clone_flags & CLONE_THREAD) ? current->tgid : p->pid; > > p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? child_tidptr : NULL; > /*
| |