Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 05/16] blackfin idle: delete pm_idle | Date | Wed, 20 Feb 2013 20:52:18 +0100 |
| |
On Monday, February 18, 2013 05:28:19 PM Lars-Peter Clausen wrote: > On 02/10/2013 06:58 AM, Len Brown wrote: > > From: Len Brown <len.brown@intel.com> > > > > pm_idle is dead code on blackfin. > > > > Signed-off-by: Len Brown <len.brown@intel.com> > > Cc: uclinux-dist-devel@blackfin.uclinux.org > > --- > > arch/blackfin/kernel/process.c | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c > > index 3e16ad9..8061426 100644 > > --- a/arch/blackfin/kernel/process.c > > +++ b/arch/blackfin/kernel/process.c > > @@ -39,12 +39,6 @@ int nr_l1stack_tasks; > > void *l1_stack_base; > > unsigned long l1_stack_len; > > > > -/* > > - * Powermanagement idle function, if any.. > > - */ > > -void (*pm_idle)(void) = NULL; > > -EXPORT_SYMBOL(pm_idle); > > - > > void (*pm_power_off)(void) = NULL; > > EXPORT_SYMBOL(pm_power_off); > > > > @@ -81,7 +75,6 @@ void cpu_idle(void) > > { > > /* endless idle loop with no priority at all */ > > while (1) { > > - void (*idle)(void) = pm_idle; > > Hi, > > This results in the following error: > > arch/blackfin/kernel/process.c: In function ‘cpu_idle’: > arch/blackfin/kernel/process.c:83: error: ‘idle’ undeclared (first use in > this function) > arch/blackfin/kernel/process.c:83: error: (Each undeclared identifier is > reported only once > arch/blackfin/kernel/process.c:83: error: for each function it appears in.) > arch/blackfin/kernel/process.c:88: error: implicit declaration of function > ‘idle’ > > > This change on top of your patch, fixes it.
Lars, I need your sign-off for the patch below. May I add it?
Rafael
> diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c > index 8061426..9782c03 100644 > --- a/arch/blackfin/kernel/process.c > +++ b/arch/blackfin/kernel/process.c > @@ -80,12 +80,10 @@ void cpu_idle(void) > if (cpu_is_offline(smp_processor_id())) > cpu_die(); > #endif > - if (!idle) > - idle = default_idle; > tick_nohz_idle_enter(); > rcu_idle_enter(); > while (!need_resched()) > - idle(); > + default_idle(); > rcu_idle_exit(); > tick_nohz_idle_exit(); > preempt_enable_no_resched(); > > > Otherwise the patch seems to work fine. > > - Lars > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |