Messages in this thread | | | Date | Wed, 20 Feb 2013 22:20:19 +0800 | From | Alex Shi <> | Subject | Re: [patch v5 11/15] sched: add power/performance balance allow flag |
| |
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 2e8131d..0047856 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -4053,6 +4053,8 @@ struct lb_env { >> unsigned int loop; >> unsigned int loop_break; >> unsigned int loop_max; >> + int power_lb; /* if power balance needed */ >> + int perf_lb; /* if performance balance needed */ > > Those look like they're used like simple boolean flags. Why not make > them such, i.e. bitfields? See struct perf_event_attr for an example.
there are 11 long words in struct lb_env now. use boolean or bitfields can't save much space. and not use conveniently. > > Thanks. >
-- Thanks Alex
| |