Messages in this thread | | | Date | Wed, 20 Feb 2013 12:20:36 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH EDAC 3/6] edac: put all arguments for the raw error handling call into a struct |
| |
On Wed, Feb 20, 2013 at 08:12:49AM -0300, Mauro Carvalho Chehab wrote: > The number of arguments for edac_raw_mc_handle_error() is too big; > put them into a structure and allocate space for it inside > edac_mc_alloc(). > > That reduces a lot the stack usage and simplifies the raw API call. > > Tested with sb_edac driver and MCE error injection. Worked as expected: > > [ 143.066100] EDAC MC0: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x320 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) > [ 143.086424] EDAC MC0: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x320 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) > [ 143.106570] EDAC MC0: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x320 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) > [ 143.126712] EDAC MC0: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x320 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0) > > Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Looks ok.
Acked-by: Borislav Petkov <bp@suse.de>
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |