lkml.org 
[lkml]   [2013]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] [SCSI] aacraid: silence two GCC warnings
From
Date
On Wed, 2013-02-20 at 10:40 +0000, James Bottomley wrote:
> On Sat, 2013-02-09 at 21:09 +0100, Paul Bolle wrote:
> > --- a/drivers/scsi/aacraid/src.c
> > +++ b/drivers/scsi/aacraid/src.c
> > @@ -407,7 +407,7 @@ static int aac_src_deliver_message(struct fib *fib)
> > fib->hw_fib_va->header.StructType = FIB_MAGIC2;
> > fib->hw_fib_va->header.SenderFibAddress = (u32)address;
> > fib->hw_fib_va->header.u.TimeStamp = 0;
> > - BUG_ON((u32)(address >> 32) != 0L);
> > + BUG_ON(((u64)address >> 32) != 0UL);
>
> Actually, this isn't the right way to do this. The correct way would be
> address >> 16 >> 16, but no-one is expected to remember this, so we have
> it macroised in kernel.h as upper_32_bits().
>
> So this should become
>
> BUG_ON(upper_32_bits(address) != 0L);

Thanks. I hadn't yet stumbled onto that macro.

> and a similar change for the below.

I hope to send an updated patch shortly.


Paul Bolle


\
 
 \ /
  Last update: 2013-02-20 12:21    [W:0.055 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site