Messages in this thread | | | Date | Sat, 2 Feb 2013 11:08:33 +0530 | Subject | Re: [PATCH 4/6] cpufreq_stats: Do not track policies without associated governors. | From | Viresh Kumar <> |
| |
On Sat, Feb 2, 2013 at 12:15 AM, <dirk.brandewie@gmail.com> wrote: > From: Dirk Brandewie <dirk.brandewie@gmail.com> > > Scaling drivers that implement internal governors do not have governor > sturctures associated with them. Do not create/remove statisitcs > entries for polices that do not have governors associated with them. > > Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
It is not based of latest work.
Why don't we want stats to be updated for these? What does stats have to do with governor?
> --- > drivers/cpufreq/cpufreq_stats.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c > index 9d7732b..8a1daf4 100644 > --- a/drivers/cpufreq/cpufreq_stats.c > +++ b/drivers/cpufreq/cpufreq_stats.c > @@ -183,7 +183,7 @@ static void cpufreq_stats_free_table(unsigned int cpu) > static void cpufreq_stats_free_sysfs(unsigned int cpu) > { > struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); > - if (policy && policy->cpu == cpu) > + if (policy && policy->cpu == cpu && policy->governor) > sysfs_remove_group(&policy->kobj, &stats_attr_group); > if (policy) > cpufreq_cpu_put(policy); > @@ -271,6 +271,8 @@ static int cpufreq_stat_notifier_policy(struct notifier_block *nb, > unsigned int cpu = policy->cpu; > if (val != CPUFREQ_NOTIFY) > return 0; > + if (!policy->governor) > + return 0; > table = cpufreq_frequency_get_table(cpu); > if (!table) > return 0; > -- > 1.7.7.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |