lkml.org 
[lkml]   [2013]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 16/62] drm/exynos: convert to idr_alloc()
    Date
    Convert to the much saner new idr interface.

    Only compile tested.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: David Airlie <airlied@linux.ie>
    Cc: Kukjin Kim <kgene.kim@samsung.com>
    Cc: dri-devel@lists.freedesktop.org
    ---
    This patch depends on an earlier idr changes and I think it would be
    best to route these together through -mm. Please holler if there's
    any objection. Thanks.

    drivers/gpu/drm/exynos/exynos_drm_ipp.c | 16 +++++-----------
    1 file changed, 5 insertions(+), 11 deletions(-)

    diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
    index 49278f0..62c24fb 100644
    --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
    +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
    @@ -137,21 +137,15 @@ static int ipp_create_id(struct idr *id_idr, struct mutex *lock, void *obj,

    DRM_DEBUG_KMS("%s\n", __func__);

    -again:
    - /* ensure there is space available to allocate a handle */
    - if (idr_pre_get(id_idr, GFP_KERNEL) == 0) {
    - DRM_ERROR("failed to get idr.\n");
    - return -ENOMEM;
    - }
    -
    /* do the allocation under our mutexlock */
    mutex_lock(lock);
    - ret = idr_get_new_above(id_idr, obj, 1, (int *)idp);
    + ret = idr_alloc(id_idr, obj, 1, 0, GFP_KERNEL);
    mutex_unlock(lock);
    - if (ret == -EAGAIN)
    - goto again;
    + if (ret < 0)
    + return ret;

    - return ret;
    + *idp = ret;
    + return 0;
    }

    static void *ipp_find_obj(struct idr *id_idr, struct mutex *lock, u32 id)
    --
    1.8.1


    \
     
     \ /
      Last update: 2013-02-03 03:41    [W:4.210 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site