lkml.org 
[lkml]   [2013]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes
On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote:
> Whenever a struct device_attribute is registered
> with mismatched permissions - read permission without
> a show routine or write permission without store
> routine - we will issue a big warning so we catch
> those early enough.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>
> This is completely untested. I have only compile tested
> to make sure I'm not breaking anything.
>
> Greg, do you think this would be nice to have ? I could
> fire up kvm tomorrow and run on a few of my OMAP-based
> boards to make sure it works as expected.

Looks good, but you better fix up all of the big offenders that this
points out, before I apply it, otherwise we will get a ton of bug
reports :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-02-18 21:01    [W:0.243 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site