[lkml]   [2013]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3] cgroup: fix cgroup_rmdir() vs close(eventfd) race
On Mon, Feb 18, 2013 at 06:56:14PM +0800, Li Zefan wrote:
> commit 205a872bd6f9a9a09ef035ef1e90185a8245cc58 ("cgroup: fix lockdep
> warning for event_control") solved a deadlock by introducing a new
> bug.
> Move cgrp->event_list to a temporary list doesn't mean you can traverse
> this list locklessly, because at the same time cgroup_event_wake() can
> be called and remove the event from the list. The result of this race
> is disastrous.
> We adopt the way how kvm irqfd code implements race-free event removal,
> which is now described in the comments in cgroup_event_wake().
> v3:
> - call eventfd_signal() no matter it's eventfd close or cgroup removal
> that removes the cgroup event.
> Acked-by: Kirill A. Shutemov <>
> Signed-off-by: Li Zefan <>

Dropped v2 and applied this one to cgroup/for-3.9.



 \ /
  Last update: 2013-02-18 19:01    [W:0.054 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site