lkml.org 
[lkml]   [2013]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686
Hi Benson,

checkpatch.pl doesn't love this syntax:

ERROR: spaces required around that ':' (ctx:ExV)
#113: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:142:
+ :"+a" (_eax), "=S" (_ebx), "=c" (_ecx), "=d" (_edx)
^

ERROR: spaces required around that ':' (ctx:ExV)
#115: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:144:
+ :"edi" /* clobbers: we hit edi directly */);
^

ERROR: trailing statements should be on next line
#116: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:145:
+ if (eax) *eax = _eax;

ERROR: trailing statements should be on next line
#117: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:146:
+ if (ebx) *ebx = _ebx;

ERROR: trailing statements should be on next line
#118: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:147:
+ if (ecx) *ecx = _ecx;

ERROR: trailing statements should be on next line
#119: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:148:
+ if (edx) *edx = _edx;

total: 6 errors, 2 warnings, 57 lines checked

/home/lenb/Documents/epp.eml has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Commit Body is:
--------------------------
tools/power x86_energy_perf_policy: fix cpuid for i686



\
 
 \ /
  Last update: 2013-02-18 06:41    [W:1.909 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site