lkml.org 
[lkml]   [2013]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sound: usb/quirks, fix out-of-bounds access
At Sun, 17 Feb 2013 14:33:04 +0100,
Jiri Slaby wrote:
>
> bootresponse in snd_usb_mbox2_boot_quirk is only 12 (decimal) u8's
> long, but i9s passed to snd_usb_ctl_msg as it would be 0x12 (hexa)
> long. Fix that by having proper size of the array, i.e. 0x12.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Damien Zammit <damien@zamaudio.com>
> Cc: Takashi Iwai <tiwai@suse.de>

A good catch. Applied now. Thanks!


Takashi

> ---
> sound/usb/quirks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 2c97185..0115289 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -533,7 +533,7 @@ static int snd_usb_mbox2_boot_quirk(struct usb_device *dev)
> {
> struct usb_host_config *config = dev->actconfig;
> int err;
> - u8 bootresponse[12];
> + u8 bootresponse[0x12];
> int fwsize;
> int count;
>
> --
> 1.8.1.2
>
>


\
 
 \ /
  Last update: 2013-02-17 18:21    [W:0.023 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site