lkml.org 
[lkml]   [2013]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[RFT][PATCH] regulator: ab8500: Remove get_voltage_sel for fixed voltage
    From
    Date
    Current code sets get_voltage_sel to ab8500_regulator_get_voltage_sel,
    however both ab8500_regulator_mode_ops and ab8500_regulator_ops do not
    have voltage_bank, voltage_reg and voltage_mask settings.
    So it looks wrong to use ab8500_regulator_get_voltage_sel as
    get_voltage_sel callback in these cases.

    A simple fix is just not implement get_voltage_sel, regulator core will
    report microvolts in sysfs even with only list_voltage().

    Signed-off-by: Axel Lin <axel.lin@ingics.com>
    ---
    Just found this needs to be fixed after I sent previous ab8500 patches,
    this patch is on top of previous ab8500 fixes.

    Axel
    drivers/regulator/ab8500.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
    index 24d490e..67b4412 100644
    --- a/drivers/regulator/ab8500.c
    +++ b/drivers/regulator/ab8500.c
    @@ -362,7 +362,6 @@ static struct regulator_ops ab8500_regulator_mode_ops = {
    .get_optimum_mode = ab8500_regulator_get_optimum_mode,
    .set_mode = ab8500_regulator_set_mode,
    .get_mode = ab8500_regulator_get_mode,
    - .get_voltage_sel = ab8500_regulator_get_voltage_sel,
    .list_voltage = regulator_list_voltage_linear,
    .set_voltage_time_sel = ab8500_regulator_set_voltage_time_sel,
    };
    @@ -371,7 +370,6 @@ static struct regulator_ops ab8500_regulator_ops = {
    .enable = ab8500_regulator_enable,
    .disable = ab8500_regulator_disable,
    .is_enabled = ab8500_regulator_is_enabled,
    - .get_voltage_sel = ab8500_regulator_get_voltage_sel,
    .list_voltage = regulator_list_voltage_linear,
    };

    --
    1.7.9.5




    \
     
     \ /
      Last update: 2013-02-18 04:41    [W:5.316 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site