lkml.org 
[lkml]   [2013]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] backlight: lm3630: remove ret = -EIO of lm3630_backlight_register()
2013년 02월 04일 09:14, Jingoo Han 쓴 글:
> There is no need to return -EIO, because backlight_device_register()
> already returns correct error values.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/lm3630_bl.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/lm3630_bl.c b/drivers/video/backlight/lm3630_bl.c
> index a6d637b..76a62e9 100644
> --- a/drivers/video/backlight/lm3630_bl.c
> +++ b/drivers/video/backlight/lm3630_bl.c
> @@ -320,7 +320,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,
> backlight_device_register(name, pchip->dev, pchip,
> &lm3630_bank_a_ops, &props);
> if (IS_ERR(pchip->bled1))
> - return -EIO;
> + return PTR_ERR(pchip->bled1);
> break;
> case BLED_2:
> props.brightness = pdata->init_brt_led2;
> @@ -329,7 +329,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,
> backlight_device_register(name, pchip->dev, pchip,
> &lm3630_bank_b_ops, &props);
> if (IS_ERR(pchip->bled2))
> - return -EIO;
> + return PTR_ERR(pchip->bled2);
> break;
> }
> return 0;

Thank you. This patch looks good for us.
Acked-by: Daniel Jeong<daniel.jeong@ti.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-02-18 03:21    [W:0.030 / U:1.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site