Messages in this thread | | | Date | Sun, 17 Feb 2013 21:01:03 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 0/3] coredump: fix the ancient signal problems |
| |
On 02/17, Oleg Nesterov wrote: > > On 02/17, Linus Torvalds wrote: > > > > SIGKILL really is very very special. Having it kill a > > coredump in progress sounds fine to me. > > Great.
Forgot to mention just in case...
We could probably make a simpler patch. do_coredump() can ignore all signals except SIGKILL from the start. But when I suggested this change in the past I was told that the dump handler looks (or may look) at /proc/pid/status so we shouldn't do this.
And instead of s/SIGNAL_GROUP_EXIT/group_exit_task/ in 2/3 we could add the ugly but simple checks in __send_signal() paths. Say we could rely on PF_DUMPCORE (which btw asks for cleanup anyway).
However, I think that using ->group_exit_task is better (if correct!) and simply more logical.
Oleg.
| |