lkml.org 
[lkml]   [2013]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] coredump: fix the ancient signal problems
On 02/17, Oleg Nesterov wrote:
>
> On 02/17, Linus Torvalds wrote:
> >
> > SIGKILL really is very very special. Having it kill a
> > coredump in progress sounds fine to me.
>
> Great.

Forgot to mention just in case...

We could probably make a simpler patch. do_coredump() can ignore
all signals except SIGKILL from the start. But when I suggested
this change in the past I was told that the dump handler looks
(or may look) at /proc/pid/status so we shouldn't do this.

And instead of s/SIGNAL_GROUP_EXIT/group_exit_task/ in 2/3 we
could add the ugly but simple checks in __send_signal() paths.
Say we could rely on PF_DUMPCORE (which btw asks for cleanup
anyway).

However, I think that using ->group_exit_task is better (if
correct!) and simply more logical.

Oleg.



\
 
 \ /
  Last update: 2013-02-17 21:21    [W:0.024 / U:3.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site