Messages in this thread | | | Date | Sat, 16 Feb 2013 18:12:28 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 4/5] freezer: clear fake signal on exit from __refrigerator |
| |
Forgot to mention...
On 02/16, Oleg Nesterov wrote: > On 02/16, Mandeep Singh Baines wrote: > > > > --- a/kernel/freezer.c > > +++ b/kernel/freezer.c > > @@ -81,6 +81,9 @@ bool __refrigerator(bool check_kthr_stop) > > */ > > set_current_state(save); > > > > + /* Clear fake signal from freeze_task(). */ > > + recalc_sigpending(); > > NACK. We can't do this lockless. > > And I am not sure we should reinstantiate it here.
And note that with the fix I propose in reply to 5/5 this change is not needed.
Oleg.
| |