Messages in this thread | | | Date | Sat, 16 Feb 2013 13:57:29 +0800 | Subject | Re: [RFC/RFT][PATCH 1/3] regulator: core: Add enable_pulldown flag to indicate pulldown on EN input | From | Haojian Zhuang <> |
| |
On Sat, Feb 16, 2013 at 1:35 PM, Axel Lin <axel.lin@ingics.com> wrote: > >> I think that enable_pulldown is a little hard to understand. How about >> change >> the name, like set_to_disable or something else? > > > How about "enable_invert"? > ( We have ena_gpio_invert setting for GPIO controlled enable lines ) > > Then I'll update the comments to: > @enable_invert: A flag to indicate set enable_mask bits to disable when > using > regulator_enable_regmap and friends APIs. > > Axel
enable_is_inverted is better.
| |