lkml.org 
[lkml]   [2013]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [Watchdog][Trivial] Added comments to explain watchdog_disabled variable
From
Date
On Sat, 2013-02-16 at 09:42 +0100, Ingo Molnar wrote:
> * Don Zickus <dzickus@redhat.com> wrote:
>
> > > >> > + /*
> > > >> > + * We shouldn't enable watchdog threads if it is
> > > >> > + * disabled.This is done by watchdog_disabled
> > > >> > + * variable check in watchdog_*_all_cpus function.
> > > >
> > > > It has two grammatic and a stylistic error in it, plus misses
> > > Would you mind pointing it out to me the grammatical mistakes
> > > as I am not that good with grammar.
> >
> > I am not entirely sure which ones Ingo is referring to, but what I see are
> >
> > 'disabled.This' needs a space after period
> > 'This is done by watchdog_disabled' needs a 'the' after 'by'
> > 'variable check in watchdog..' needs a 'the' after 'in'.
> >
> > in addition to the missing ()'s after 'watchdog_*_all_cpus.
>
> There's also a plural/singular mismatch between 'watchdog
> threads' and 'if it is disabled'.
Thanks, I will update the same in the next patch.
>
> Thanks,
>
> Ingo




\
 
 \ /
  Last update: 2013-02-16 13:21    [W:0.043 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site