Messages in this thread | | | Date | Sat, 16 Feb 2013 13:27:57 -0800 | From | Anton Vorontsov <> | Subject | Re: [patch] generic-adc-battery: forever loop in gab_remove() |
| |
On Thu, Feb 14, 2013 at 10:26:43AM +0300, Dan Carpenter wrote: > There is a forever loop calling iio_channel_release() because the > "chan < " part of the "chan < ARRAY_SIZE()" is missing. This is in both > the error handling on probe and also in the remove function. > > The other thing is that it's possible for some of the elements of the > adc_bat->channel[chan] array to be an ERR_PTR(). I've changed them to > be NULL instead. We're still not allowed to pass NULLs to > iio_channel_release() so I've added a check. > > Finally, I removed an unused "chan = ARRAY_SIZE(gab_chan_name);" > statement as a small cleanup. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks a lot!
Anton
| |