lkml.org 
[lkml]   [2013]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: pt_regs leak into userspace (was Re: [PATCH v3 20/71] ARC: Signal handling)
From
On 11 February 2013 15:07, Al Viro <viro@zeniv.linux.org.uk> wrote:

> I'd suggest asking itanic folks; they do *not* put callee-saved stuff into
> sigcontext. AFAICS, they don't have setcontext() implemented as a syscall
> at all - it's done as sigprocmask() + doing to callee-saved registers what
> longjmp() does.


Just to round off this discussion, after giving it some more thought I
agree that the case where you would need callee-saved registers
restored is probably rather pathological. Any sane use of
get/set/swapcontext is manageable without this.

So, Vineet, I'm now convinced your approach is sound. I will probably
amend the OpenRISC arch to behave similarly. Consider your entire
patch Acked now.

/Jonas


\
 
 \ /
  Last update: 2013-02-15 09:01    [W:0.131 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site