Messages in this thread Patch in this message | | | From | Mandeep Singh Baines <> | Subject | [PATCH 5/5] coredump: abort core dump piping only due to a fatal signal | Date | Thu, 14 Feb 2013 15:38:16 -0800 |
| |
From: Ben Chan <benchan@chromium.org>
This patch makes wait_for_dump_helpers() not to abort piping the core dump data when the crashing process has received any but a fatal signal (SIGKILL). The rationale is that a crashing process may still receive uninteresting signals such as SIGCHLD when its core dump data is being redirected to a helper application. While it's necessary to allow terminating the core dump piping via SIGKILL, it's practically more useful for the purpose of debugging and crash reporting if the core dump piping is not aborted due to other non-fatal signals.
Signed-off-by: Ben Chan <benchan@chromium.org> Signed-off-by: Mandeep Singh Baines <msb@chromium.org> CC: Oleg Nesterov <oleg@redhat.com> CC: Tejun Heo <tj@kernel.org> CC: Andrew Morton <akpm@linux-foundation.org> CC: Rafael J. Wysocki <rjw@sisk.pl> CC: Ingo Molnar <mingo@redhat.com> --- fs/coredump.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/coredump.c b/fs/coredump.c index 1774932..54e31a3 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -32,6 +32,7 @@ #include <linux/pipe_fs_i.h> #include <linux/oom.h> #include <linux/compat.h> +#include <linux/freezer.h> #include <asm/uaccess.h> #include <asm/mmu_context.h> @@ -417,10 +418,13 @@ static void wait_for_dump_helpers(struct file *file) pipe->readers++; pipe->writers--; - while ((pipe->readers > 1) && (!signal_pending(current))) { + while ((pipe->readers > 1) && (!fatal_signal_pending(current))) { wake_up_interruptible_sync(&pipe->wait); kill_fasync(&pipe->fasync_readers, SIGIO, POLL_IN); pipe_wait(pipe); + pipe_unlock(pipe); + try_to_freeze(); + pipe_lock(pipe); } pipe->readers--; -- 1.8.1
| |