Messages in this thread | | | Date | Wed, 13 Feb 2013 13:42:15 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 02/10] Input: atmel_mxt_ts - register input device before request_irq |
| |
Hi Daniel,
On Fri, Feb 01, 2013 at 04:11:44PM +0800, Daniel Kurtz wrote: > As soon as the irq is request, input event interrupts could occur that > the isr should handle. Similarly, if there are input events queued up > in the device output buffer, it will send them immediately when we > drain the message buffer with mxt_handle_messages. > > Therefore, register the input device before enabling the irq (or handling > messages).
I do not see the point. The allocated device can withstand input_events() calls even without being registered and I am not sure why anyone would be particularly interested in events that happened before or during device registration, espceially for a touchscreen device.
Thanks.
-- Dmitry
| |