lkml.org 
[lkml]   [2013]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] perf, x86: Basic Haswell PMU support v4

* Andi Kleen <andi@firstfloor.org> wrote:

> +static int hsw_hw_config(struct perf_event *event)
> +{
> + int ret = intel_pmu_hw_config(event);
> +
> + if (ret)
> + return ret;
> + if (!boot_cpu_has(X86_FEATURE_RTM) && !boot_cpu_has(X86_FEATURE_HLE))
> + return 0;
> + event->hw.config |= event->attr.config & (HSW_INTX|HSW_INTX_CHECKPOINTED);
> +
> + /*
> + * INTX/INTX-CP do not play well with PEBS or ANY thread mode.
> + */
> + if ((event->hw.config & (HSW_INTX|HSW_INTX_CHECKPOINTED)) &&
> + ((event->hw.config & ARCH_PERFMON_EVENTSEL_ANY) ||
> + event->attr.precise_ip > 0))
> + return -EOPNOTSUPP;

Please explain it more verbosely in the comment what 'do not
play well' means and why it necessiates a -EOPNOTSUPP reply.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-02-13 10:01    [W:1.830 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site