Messages in this thread | | | Date | Wed, 13 Feb 2013 10:49:58 +0100 (CET) | From | Guennadi Liakhovetski <> | Subject | Re: [PATCH] regulator: as3711: Fix checking if no platform initialization data |
| |
On Wed, 13 Feb 2013, Axel Lin wrote:
> To skip registering regulator if no platform initialization data, > we should check reg_data rather than ri->desc.name. > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks Guennadi
> --- > drivers/regulator/as3711-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/as3711-regulator.c b/drivers/regulator/as3711-regulator.c > index 2f1341d..f0ba8c4 100644 > --- a/drivers/regulator/as3711-regulator.c > +++ b/drivers/regulator/as3711-regulator.c > @@ -303,7 +303,7 @@ static int as3711_regulator_probe(struct platform_device *pdev) > reg_data = pdata ? pdata->init_data[id] : NULL; > > /* No need to register if there is no regulator data */ > - if (!ri->desc.name) > + if (!reg_data) > continue; > > reg = ®s[id]; > -- > 1.7.9.5 > > >
--- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/
| |