Messages in this thread | | | Date | Tue, 12 Feb 2013 11:34:55 +0100 | From | Samuel Ortiz <> | Subject | Re: [PATCH] lpc_sch: Accomodate partial population of the MFD devices |
| |
Hi Darren,
On Fri, Feb 08, 2013 at 03:20:36PM -0800, Darren Hart wrote: > The current probe aborts if any of the 3 base address registers are > disabled. On a TunnelCreek system I am working on, this resulted in the > SMBIOS and GPIO devices being removed when it couldn't read the base > address for the watchdog timer. > > This patch accommodates partial population of the lpc_sch_cells array and > only aborts if all the base address registers are disabled. A max size > array is allocated and the individual device cells are added to it after > their base addresses are successfully determined. This simplifies the > code a bit by removing the need for the separate tunnelcreek cells array > and combining some of the add/remove logic. > > Signed-off-by: Darren Hart <dvhart@linux.intel.com> > Cc: Grant Likely <grant.likely@secretlab.ca>, > Cc: Denis Turischev <denis@compulab.co.il>, > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Signed-off-by: Darren Hart <dvhart@linux.intel.com> > --- > drivers/mfd/lpc_sch.c | 148 ++++++++++++++++++++++++-------------------------- > 1 file changed, 70 insertions(+), 78 deletions(-) Patch applied, thanks.
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |