lkml.org 
[lkml]   [2013]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux-next] hugetlbfs: hugetlbfs_fill_super(): remove kfree() redundant null check
Acked-by: Nadia Yvette Chambers <nyc@holomorphy.com>


On February 12, 2013 at 1:17 PM Tim Gardner <tim.gardner@canonical.com> wrote:

> smatch analysis:
>
> fs/hugetlbfs/inode.c:883 hugetlbfs_fill_super() info: redundant null check on
> sbinfo->spool calling kfree()
>
> Cc: Nadia Yvette Chambers <nyc@holomorphy.com>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
> fs/hugetlbfs/inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 78bde32..e2e36ef 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -879,8 +879,7 @@ hugetlbfs_fill_super(struct super_block *sb, void *data,
> int silent)
> goto out_free;
> return 0;
> out_free:
> - if (sbinfo->spool)
> - kfree(sbinfo->spool);
> + kfree(sbinfo->spool);
> kfree(sbinfo);
> return -ENOMEM;
> }
> --
> 1.7.9.5
>


\
 
 \ /
  Last update: 2013-02-12 23:03    [W:0.533 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site