lkml.org 
[lkml]   [2013]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 21/22] tg3: Avoid null pointer dereference in tg3_interrupt in netconsole mode
    Date
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: Nithin Nayak Sujir <nsujir@broadcom.com>

    [ Upstream commit 9c13cb8bb477a83b9a3c9e5a5478a4e21294a760 ]

    When netconsole is enabled, logging messages generated during tg3_open
    can result in a null pointer dereference for the uninitialized tg3
    status block. Use the irq_sync flag to disable polling in the early
    stages. irq_sync is cleared when the driver is enabling interrupts after
    all initialization is completed.

    Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
    Signed-off-by: Michael Chan <mchan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/tg3.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/net/tg3.c
    +++ b/drivers/net/tg3.c
    @@ -5662,6 +5662,9 @@ static void tg3_poll_controller(struct n
    int i;
    struct tg3 *tp = netdev_priv(dev);

    + if (tg3_irq_sync(tp))
    + return;
    +
    for (i = 0; i < tp->irq_cnt; i++)
    tg3_interrupt(tp->napi[i].irq_vec, &tp->napi[i]);
    }
    @@ -14981,6 +14984,7 @@ static int __devinit tg3_init_one(struct
    tp->pm_cap = pm_cap;
    tp->rx_mode = TG3_DEF_RX_MODE;
    tp->tx_mode = TG3_DEF_TX_MODE;
    + tp->irq_sync = 1;

    if (tg3_debug > 0)
    tp->msg_enable = tg3_debug;



    \
     
     \ /
      Last update: 2013-02-12 23:02    [W:5.036 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site