Messages in this thread | | | Date | Tue, 12 Feb 2013 12:13:24 -0800 (PST) | From | David Rientjes <> | Subject | Re: [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled |
| |
On Tue, 12 Feb 2013, Linus Torvalds wrote:
> On Tue, Feb 12, 2013 at 1:50 AM, Steven Whitehouse <swhiteho@redhat.com> wrote: > > > > That doesn't seem right to me... DLM has not been experimental for a > > long time now. Why not just select CRC32 in addition to IP_SCTP ? > > Hmm. IP_SCTP already does a "select libcrc32c". So why doesn't that > end up working? >
Kconfig won't select things that CONFIG_IP_SCTP select unless its "depends on" are satisfied, which is why I made CONFIG_DLM depend on CONFIG_EXPERIMENTAL.
Steven says DLM hasn't been experimental for a long time; sorry, but if an option you select is experimental then you're experimental as well.
If you'd like to push a patch that removes EXPERIMENTAL from IP_SCTP to David Miller, that works too. But that is a completely separate topic from dlm. For 3.8, I suggest respecting CONFIG_IP_SCTP's requirements and then removing EXPERIMENTAL from both if the networking guys agree.
| |