Messages in this thread | | | Date | Tue, 12 Feb 2013 09:35:12 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings |
| |
On 02/12/2013 09:32 AM, Linus Torvalds wrote: > On Tue, Feb 12, 2013 at 9:14 AM, H. Peter Anvin <hpa@zytor.com> wrote: >> >> No, I think what he is talking about it this bit: > > Ok, I agree that the bitfield code actually looks cleaner. > > That said, maybe gcc has an easier time using a few odd builtins and > magic typeof's. But at least the bitfield trick looks half-way > portable.. >
On the other hand, it still uses two gcc extensions: long long bitfields and typeof.
I'll see what kind of code we get with the macro.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |