Messages in this thread | | | Date | Tue, 12 Feb 2013 11:17:39 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH V4 1/2] get_maintainer: allow keywords to match filenames |
| |
On 02/11/2013 11:17 PM, Joe Perches wrote: > On Mon, 2013-02-11 at 17:39 -0700, Stephen Warren wrote: >> From: Stephen Warren <swarren@nvidia.com> >> >> Allow K: entries in MAINTAINERS to match directly against filenames; >> either those extracted from patch +++ or --- lines, or those specified >> on the command-line using the -f option. > [] >> diff --git a/MAINTAINERS b/MAINTAINERS > [] >> @@ -97,12 +97,12 @@ Descriptions of section entries: >> X: net/ipv6/ >> matches all files in and below net excluding net/ipv6/ >> K: Keyword perl extended regex pattern to match content in a >> - patch or file. For instance: >> + patch, or an affected filename. For instance: > > The removal of file isn't correct. > > This should read "patch, file or filename". > > If the -f pattern is a single file, > get_maintainer reads that file content and then > matches any K: patterns. > > When the -f pattern is a directory, it doesn't.
Yes, I guess that's true; I had convinced myself that "file" wasn't accurate since "-f directory/" didn't scan the files within that directory tree, but as you say "-f file" does scan the file content.
BTW, given I'm adding "filename" to the list, I intend to change the existing "file" to "file content" to be clear. Are you OK with that?
| |