lkml.org 
[lkml]   [2013]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux-next] befs: befs_fill_super(): remove unreachable code
On 02/12/2013 10:46 AM, Eric W. Biederman wrote:
> Tim Gardner <tim.gardner@canonical.com> writes:
>
>> befs_sb->num_blocks is of base type u64 which is the same as sector_t.
>> Therefore, num_blocks can never be larger then the maximum
>> value of sector_t.
>
> The analysys is wrong. On 32bit with CONFIG_LBAF unset sector_t is an
> unsigned long aka a u32, while befs_off_t is always a u64.
>
> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>

Dang - you're right.

--
Tim Gardner tim.gardner@canonical.com


\
 
 \ /
  Last update: 2013-02-12 19:41    [W:0.027 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site