Messages in this thread | | | Date | Tue, 12 Feb 2013 11:07:36 -0700 | From | Tim Gardner <> | Subject | Re: [PATCH linux-next] befs: befs_fill_super(): remove unreachable code |
| |
On 02/12/2013 10:46 AM, Eric W. Biederman wrote: > Tim Gardner <tim.gardner@canonical.com> writes: > >> befs_sb->num_blocks is of base type u64 which is the same as sector_t. >> Therefore, num_blocks can never be larger then the maximum >> value of sector_t. > > The analysys is wrong. On 32bit with CONFIG_LBAF unset sector_t is an > unsigned long aka a u32, while befs_off_t is always a u64. > > Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Dang - you're right.
-- Tim Gardner tim.gardner@canonical.com
| |