Messages in this thread | | | Date | Tue, 12 Feb 2013 08:28:02 -0800 | From | Vinod Koul <> | Subject | Re: [PATCH] ioatdma: fix race between updating ioat->head and IOAT_COMPLETION_PENDING |
| |
On Thu, Feb 07, 2013 at 02:38:32PM -0700, Dave Jiang wrote: > There is a race that can hit during __cleanup() when the ioat->head pointer is > incremented during descriptor submission. The __cleanup() can clear the > PENDING flag when it does not see any active descriptors. This causes new > submitted descriptors to be ignored because the COMPLETION_PENDING flag is > cleared. This was introduced when code was adapted from ioatdma v1 to ioatdma > v2. For v2 and v3, IOAT_COMPLETION_PENDING flag will be abandoned and a new > flag IOAT_CHAN_ACTIVE will be utilized. This flag will also be protected under > the prep_lock when being modified in order to avoid the race. > > Signed-off-by: Dave Jiang <dave.jiang@intel.com> > Reviewed-by: Dan Williams <djbw@fb.com> Applied, thanks
-- ~Vinod
| |