Messages in this thread | | | Date | Tue, 12 Feb 2013 08:10:18 -0800 | From | Vinod Koul <> | Subject | Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers |
| |
On Fri, Feb 08, 2013 at 09:25:11AM +0200, Andy Shevchenko wrote: > On Fri, Feb 8, 2013 at 6:28 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > > On Thu, Feb 7, 2013 at 10:35 PM, Andy Shevchenko > > <andy.shevchenko@gmail.com> wrote: > >> On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > >>> On 7 February 2013 21:06, Andy Shevchenko > >>> <andriy.shevchenko@linux.intel.com> wrote: > >>>> From: Mika Westerberg <mika.westerberg@linux.intel.com> > ... > >>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > >>> > >>> Looks like Mika is Author and you have your signed-off :) > >> > >> In this literally small and clear patch it doesn't matter who is who. > > > > I believe it doesn't matter how small or big is the patch, but the author should > > be there in SOBs too.. > True. Then in that case you need to re-read Documentation/SubmittingPatches SOB is also acnowlegement of Origin of the Code, hence mandatory even for single line of change. > > > >> However for sake of equity I could add Mika's signed-off-by as well. > >> > >> It should be: > >> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > > Thanks. > > Shall I resend it? It will fix it up, and thanks to greg now you owe me a beverage :) > > -- > With Best Regards, > Andy Shevchenko
| |